Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renamed from (deprecated) service to kleisli #2613

Merged
merged 3 commits into from Jun 10, 2019

Conversation

@TomTriple
Copy link
Contributor

commented Jun 1, 2019

No description provided.

correction
Co-Authored-By: Diego E. Alonso Blas <diesalbla@gmail.com>
@@ -8,8 +8,8 @@ import cats.data.{Kleisli, OptionT}

trait KleisliSyntax {
implicit def http4sKleisliResponseSyntax[F[_]: Functor, A](

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jun 3, 2019

Member

Aside: maybe we should have had optiont in the name here in case we had syntax for other transformers. The parametric A is what prevents it from being just HttpRoutes.

This comment has been minimized.

Copy link
@TomTriple

TomTriple Jun 3, 2019

Author Contributor

Renaming breaks a test in BlazeClientSpec, so I removed that again ;)

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jun 3, 2019

Member

BlackClientSpec is regrettably flaky on Travis CI, so unless it broke locally, I'll bet it wasn't you who broke it.

This comment has been minimized.

Copy link
@TomTriple

TomTriple Jun 4, 2019

Author Contributor

I'll have a look at it again when I'm back home

This comment has been minimized.

Copy link
@TomTriple

TomTriple Jun 4, 2019

Author Contributor

You won your bet, it worked locally!

@@ -8,8 +8,8 @@ import cats.data.{Kleisli, OptionT}

trait KleisliSyntax {
implicit def http4sKleisliResponseSyntax[F[_]: Functor, A](
service: Kleisli[OptionT[F, ?], A, Response[F]]): KleisliResponseOps[F, A] =
new KleisliResponseOps[F, A](service)
kleisli: Kleisli[OptionT[F, ?], A, Response[F]]): KleisliResponseOps[F, A] =

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jun 3, 2019

Member

It's technically a source-breaking change to change a parameter name, but since @deprecatedName is deprecated between 2.12 and 2.13, and this is used only implicitly, I'm not inclined to worry about it.

This comment has been minimized.

Copy link
@TomTriple

TomTriple Jun 3, 2019

Author Contributor

Interesting to know @rossabaker ! I did not think for a second about that.

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jun 3, 2019

Member

This is something to be more careful of on things like case classes, or functions and constructors that take a few arguments. Particularly when functions take more than one argument of the same type, people are likely to call things with named parameters. But yeah, it's rare for people to call by name on unary functions, and even rarer on implicits.

@TomTriple TomTriple force-pushed the TomTriple:feature/rename-to-kleisli branch from 24085fa to a11e40d Jun 3, 2019

Thomas Hoefer

@rossabaker rossabaker merged commit e036356 into http4s:master Jun 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.