Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't depend on laziness of SSLContext in blaze-client #2624

Merged
merged 4 commits into from Jun 10, 2019

Conversation

@rossabaker
Copy link
Member

commented Jun 6, 2019

Changes the Option[SSLContext] to be truly optional instead of a sneaky laziness in the innards of the client.

The default remains Some(SSLContext.getDefault()), except on systems where this fails, in which case the error is caught and SSL is disabled. Any client may now opt out of SSL support by calling withoutSslContext. Making an https call on a client where SSL is disabled now results in an IllegalStateException with suggestions how to configure it, rather than throwing whatever exception may come from SSLContext.getDefault().

Refines the changes in #2604. Is binary compatible, but changes the behavior of weird cases.

@rossabaker

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

@nigredo-tori might also be interested in this as the reporter of the original bug, twice.

@nigredo-tori

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@rossabaker, 👍 from me.

@rossabaker

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

The test failure is real. Something about Scala 2.13 or the new Specs2 version we use in it.

@aeons aeons merged commit d53be3e into http4s:master Jun 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.