Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass RedactHeadersWith from RequestLogger #2638

Merged

Conversation

@ChristopherDavenport
Copy link
Member

commented Jun 12, 2019

Correct Branch this time

@ChristopherDavenport

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

Suggestion for 0.21, what if we removed the default from Logger.logMessage that way we are passing something whenever we call this method.

@rossabaker rossabaker merged commit 66fb1f3 into http4s:series/0.20 Jun 12, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ChristopherDavenport ChristopherDavenport deleted the ChristopherDavenport:passAlongRedactHeadersWith branch Jun 12, 2019

@rossabaker rossabaker referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.