Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string literal in Router example #2645

Merged
merged 1 commit into from Jun 13, 2019
Merged

Fix string literal in Router example #2645

merged 1 commit into from Jun 13, 2019

Conversation

@knuton
Copy link
Contributor

@knuton knuton commented Jun 13, 2019

The syntax error causes confusing noise in the docs.

The syntax error causes confusing noise in the docs.
aeons
aeons approved these changes Jun 13, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Thanks!

Loading

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 13, 2019

Hmm, why are we using nofail there? Would that example not compile for other reasons?

Loading

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jun 13, 2019

@rossabaker Yeah, the services it references don't exist.

Loading

@aeons aeons merged commit 4732c48 into http4s:master Jun 13, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants