Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generateMimeDb an sbt task instead of a project #2648

Merged
merged 3 commits into from Jun 16, 2019

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 16, 2019

Run with core/generateMimeDb

Pros:

  • It's only needed on one Scala version
  • This is blocking #2493
  • We can get rid of that thirteen nonsense now that boopickle is published and this is no longer a module
  • core/generateMimeDb is a fairly reasonable way to generate it.

Cons:

  • Puts a lot on the sbt classpath, including an older version of ourselves

Mitigation:

  • It doesn't have to use circe or http4s, but I'd rather lazily port to something we like less if it bites.
Copy link
Member

@cquiroz cquiroz left a comment

Makes sense to convert it to a plugin LGTM

Loading

aeons
aeons approved these changes Jun 16, 2019
Copy link
Member

@aeons aeons left a comment

LGTM.

It looks like the generated file has not been scalafmt'ed though.

Loading

@aeons aeons merged commit 0f4563f into http4s:master Jun 16, 2019
1 check passed
Loading
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jun 16, 2019

Oh, it'd be neat if the task scalafmt'ed it, too. I didn't even think about that. At least this unblocks 2.13.

Loading

@rossabaker rossabaker deleted the mimedb-plugin branch Jun 16, 2019
@cquiroz
Copy link
Member

@cquiroz cquiroz commented Jun 16, 2019

It sounds a good idea to format after generation. I could give it a shot

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants