Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move string context macros to implicits #2661

Merged

Conversation

@rossabaker
Copy link
Member

commented Jun 20, 2019

Fixes #2616.

@rossabaker

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

I would like to add a scalafix, but could not quickly find an exmaple that adds an import. Rewriting to an explicit invocation of the string context is plausible, but, ugh. Does anybody have a model for this?

@aeons

aeons approved these changes Jun 20, 2019

@rossabaker rossabaker merged commit df1b87e into http4s:master Jun 23, 2019

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@rossabaker rossabaker deleted the rossabaker:move-string-contexts-to-implicits branch Jun 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.