Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a modeled Ipv4Address #2679

Merged
merged 3 commits into from Jul 5, 2019
Merged

Create a modeled Ipv4Address #2679

merged 3 commits into from Jul 5, 2019

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 27, 2019

  • Replace IPv4 wrapper around CaseInsensitiveString with Ipv4Address, a case class of four bytes
  • Add an ipv4 interpolator
  • Interop with Inet4Address
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jul 3, 2019

Interesting, unrelated error here. I can't reproduce it.

[info] decode should
[error]   x be consistent with utf8Decode (1 second, 564 ms)
[error]    Falsified after 92 passed tests.
[error]    > ARG_0: ""
[error]    > ARG_0_ORIGINAL: "兦냡䶏骧ⶾ䙅"
[error]    > ARG_1: 1
[error]    > ARG_1_ORIGINAL: 1445009706
[error]    The seed is e5-vbNb5f12ZKua5LXDAI4s5eyLtnY5RGUIoFXj0JEE=
[error]    
[error]    > '' != '' (DecodeSpec.scala:24)
[error] org.http4s.util.DecodeSpec.$anonfun$new$4(DecodeSpec.scala:24)

Loading

@aeons
Copy link
Member

@aeons aeons commented Jul 3, 2019

Is the casing change intentional? IPv4 -> IpV4

Loading

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Jul 3, 2019

Dating back to my Java days, I don't capitalize acronyms, so Ip. V begins a new word, so it's capitalized. Hence IpV4. Though we could say the V is part of the same acronym, and Ipv4. Or we could stylize it like the spec, and IPv4. I guess I can justify any of the three. Strong opinions welcome.

Loading

@rossabaker rossabaker changed the title Create a modeled IpV4Address Create a modeled Ipv4Address Jul 5, 2019
@aeons
Copy link
Member

@aeons aeons commented Jul 5, 2019

I can accept Ipv4 :D

Loading

aeons
aeons approved these changes Jul 5, 2019
@rossabaker rossabaker merged commit d35e3cb into master Jul 5, 2019
2 checks passed
Loading
@rossabaker rossabaker deleted the ipv4address branch Jul 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants