Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispose of current connection before retrying #2691

Merged
merged 2 commits into from Jul 6, 2019

Conversation

@rossabaker
Copy link
Member

commented Jul 4, 2019

Fixes #2677. I wanted to fix this on 0.20, but was stopped by two things:

  1. It needs continual, which is introduced in cats-effect-2.

  2. We could backport continual to an internal util on 0.20, but then we'd need a Concurrent constraint. We'd have to deprecate the existing apply, introduce a new signature, and then reverse the deprecation in 0.21.

@rossabaker rossabaker merged commit 7810d35 into http4s:master Jul 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:issue-2677 branch Jul 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.