Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to circe-0.12.0-M4, drop scala-2.11 #2694

Merged
merged 5 commits into from Jul 5, 2019

Conversation

@rossabaker
Copy link
Member

commented Jul 5, 2019

Discussion at #2660.

@@ -129,7 +129,7 @@ object QValue {
@deprecated("""use qValue"" string interpolation instead""", "0.20")
def q(d: Double): QValue = macro Macros.qValueLiteral

implicit val http4sOrderForQValue: Order[QValue] = Order.fromOrdering[QValue]
implicit lazy val http4sOrderForQValue: Order[QValue] = Order.fromOrdering[QValue]

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jul 5, 2019

Author Member

It's not immediately clear to me why this became necessary. Without it, we get:

[error] cannot create an instance for class org.http4s.testing.ResponseGeneratorSpec
[error]   caused by java.lang.ExceptionInInitializerError
[error]   caused by scala.UninitializedFieldError: Uninitialized field: /home/travis/build/http4s/http4s/core/src/main/scala/org/http4s/QValue.scala: 132

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jul 5, 2019

Author Member

Okay, this is now causing a stack overflow error. I'm reaching the stupid hours... what's suddenly wrong with this?

This comment has been minimized.

Copy link
@travisbrown

travisbrown Jul 5, 2019

The issue is the new import pulling in catsKernelOrderingForOrder, which has higher precedence than the Ordering-from-Ordered stuff. You could either hide it, or only import catsSyntaxEither, or (what I'd do) not use valueOr.

This comment has been minimized.

Copy link
@rossabaker

rossabaker Jul 5, 2019

Author Member

Oof, thanks. I'd moved on to a different branch and was stupefied by what import was even causing it. As usual, I should have quit an hour before I did.

@aeons

aeons approved these changes Jul 5, 2019

@rossabaker rossabaker force-pushed the rossabaker:drop-2.11 branch from 2ee1d29 to b230818 Jul 5, 2019

ChristopherDavenport added some commits Jul 5, 2019

@ChristopherDavenport

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

Test failure is a flaky test on Timeout Middleware.

@ChristopherDavenport ChristopherDavenport merged commit 41bd92e into http4s:master Jul 5, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.