Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to circe-0.12.0-M4, drop scala-2.11 #2694

Merged
merged 5 commits into from Jul 5, 2019

Conversation

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jul 5, 2019

Discussion at #2660.

@@ -129,7 +129,7 @@ object QValue {
@deprecated("""use qValue"" string interpolation instead""", "0.20")
def q(d: Double): QValue = macro Macros.qValueLiteral

implicit val http4sOrderForQValue: Order[QValue] = Order.fromOrdering[QValue]
implicit lazy val http4sOrderForQValue: Order[QValue] = Order.fromOrdering[QValue]
Copy link
Member Author

@rossabaker rossabaker Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not immediately clear to me why this became necessary. Without it, we get:

[error] cannot create an instance for class org.http4s.testing.ResponseGeneratorSpec
[error]   caused by java.lang.ExceptionInInitializerError
[error]   caused by scala.UninitializedFieldError: Uninitialized field: /home/travis/build/http4s/http4s/core/src/main/scala/org/http4s/QValue.scala: 132

Loading

Copy link
Member Author

@rossabaker rossabaker Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this is now causing a stack overflow error. I'm reaching the stupid hours... what's suddenly wrong with this?

Loading

Copy link
Contributor

@travisbrown travisbrown Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is the new import pulling in catsKernelOrderingForOrder, which has higher precedence than the Ordering-from-Ordered stuff. You could either hide it, or only import catsSyntaxEither, or (what I'd do) not use valueOr.

Loading

Copy link
Member Author

@rossabaker rossabaker Jul 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, thanks. I'd moved on to a different branch and was stupefied by what import was even causing it. As usual, I should have quit an hour before I did.

Loading

aeons
aeons approved these changes Jul 5, 2019
@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jul 5, 2019

Test failure is a flaky test on Timeout Middleware.

Loading

@ChristopherDavenport ChristopherDavenport merged commit 41bd92e into http4s:master Jul 5, 2019
1 check failed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants