Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafeRunSync->unsafeRunAsync to prevent deadlocks #2737

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@Dennis4b
Copy link

@Dennis4b Dennis4b commented Jul 22, 2019

When a websocket connection is closing, stageShutdown can be called from
within another effect. If this then calls unsafeRunSync, there exists
the risk of a deadlock. Changing to unsafeRunAsync does not change the
semantics and removes this risk.

When a websocket connection is closing, stageShutdown can be called from
within another effect. If this then calls unsafeRunSync, there exists
the risk of a deadlock. Changing to unsafeRunAsync does not change the
semantics and removes this risk.
Copy link
Member

@rossabaker rossabaker left a comment

Thanks!

Loading

@rossabaker rossabaker merged commit 095fca2 into http4s:series/0.20 Jul 23, 2019
1 check passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants