Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unsafeRunSync->unsafeRunAsync to prevent deadlocks #2737

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@Dennis4b
Copy link

commented Jul 22, 2019

When a websocket connection is closing, stageShutdown can be called from
within another effect. If this then calls unsafeRunSync, there exists
the risk of a deadlock. Changing to unsafeRunAsync does not change the
semantics and removes this risk.

Dennis4b
unsafeRunSync->unsafeRunAsync to prevent deadlocks
When a websocket connection is closing, stageShutdown can be called from
within another effect. If this then calls unsafeRunSync, there exists
the risk of a deadlock. Changing to unsafeRunAsync does not change the
semantics and removes this risk.
@rossabaker
Copy link
Member

left a comment

Thanks!

@rossabaker rossabaker merged commit 095fca2 into http4s:series/0.20 Jul 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.