Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Method imports for client DSL in docs #2740

merged 2 commits into from Jul 30, 2019


Copy link

@sloshy sloshy commented Jul 27, 2019

Clarifies the documentation to specify that org.http4s.Methods._ is imported into scope with the default routing DSL, and that the client DSL needs an extra import in order for some of the examples to compile.

Changes could/should also be made for the current 0.20.x documentation, if it all looks good I'll write this up for that as well.

Copy link

@rossabaker rossabaker commented Jul 29, 2019

Thanks, @sloshy. I think the build is failing because it's Method, not Methods. The clarification is helpful!


Copy link

@sloshy sloshy commented Jul 29, 2019

@rossabaker You're right - my mistake. Should be fixed up now.


@rossabaker rossabaker merged commit abebad4 into http4s:master Jul 30, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants