Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add ResponseHeaderTimeoutStage on infinite timeout #2761

merged 2 commits into from Aug 6, 2019


Copy link

@rossabaker rossabaker commented Aug 6, 2019

Also fixes #2760 by restricting that to a FiniteDuration. As a bonus, stop calling .toMillis to guard against regressions that are hard to test when we're not in debug logging.

F.asyncF[TimeoutException] { cb =>
F.delay(stage.init(cb)) >> gate.complete(())
})(stage => F.delay(stage.removeStage()))
responseHeaderTimeout match {
Copy link
Member Author

@rossabaker rossabaker Aug 6, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scalafmt made this look bigger than it is. In short, just return the response if there's nothing finite to race against.


aeons approved these changes Aug 6, 2019
@rossabaker rossabaker merged commit c820a76 into http4s:series/0.20 Aug 6, 2019
2 checks passed
@rossabaker rossabaker deleted the issue-2760 branch Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants