Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add ResponseHeaderTimeoutStage on infinite timeout #2761

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@rossabaker
Copy link
Member

commented Aug 6, 2019

Also fixes #2760 by restricting that to a FiniteDuration. As a bonus, stop calling .toMillis to guard against regressions that are hard to test when we're not in debug logging.

F.asyncF[TimeoutException] { cb =>
F.delay(stage.init(cb)) >> gate.complete(())
})(stage => F.delay(stage.removeStage()))
responseHeaderTimeout match {

This comment has been minimized.

Copy link
@rossabaker

rossabaker Aug 6, 2019

Author Member

scalafmt made this look bigger than it is. In short, just return the response if there's nothing finite to race against.

@aeons

aeons approved these changes Aug 6, 2019

@rossabaker rossabaker merged commit c820a76 into http4s:series/0.20 Aug 6, 2019

2 checks passed

Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@rossabaker rossabaker deleted the rossabaker:issue-2760 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.