Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More useful defaults for JettyClient #2817

Merged

Conversation

@IndiscriminateCoding
Copy link
Contributor

@IndiscriminateCoding IndiscriminateCoding commented Aug 26, 2019

This PR changes default JettyClient:

  1. Enabled SSL support
  2. Disabled default Content-Type. It's inconvenient to have application/octet-stream by default because it is set even if the body is empty. See also.
Copy link
Member

@rossabaker rossabaker left a comment

👍 Thanks!

Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Seems ok, does the sslcontextfactory need a delay to construct? Other ssl tools we've engage have been partial in construction across OS's I think.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Aug 27, 2019

Oh, that's a good point. It was relevant in blaze because it's a default argument, and this is, too.

We've gotten around these effectful default arguments elsewhere with a Resource and a builder pattern.

@IndiscriminateCoding
Copy link
Contributor Author

@IndiscriminateCoding IndiscriminateCoding commented Aug 27, 2019

Ok, I've removed SslContextFactory.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Aug 27, 2019

It's frustrating that we don't get an SSL client of the box to work around a problem that hits a tiny minority of JVMs. We should figure out better, but this is progress.

@rossabaker rossabaker merged commit 6405784 into http4s:series/0.20 Aug 28, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants