Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Url decoding/encoding to Uri companion object #2830

Merged
merged 5 commits into from Sep 19, 2019

Conversation

@IndiscriminateCoding
Copy link
Contributor

@IndiscriminateCoding IndiscriminateCoding commented Aug 30, 2019

No description provided.

@IndiscriminateCoding IndiscriminateCoding changed the title Move Url decoding functions to Uri companion object Move Url decoding/encoding to Uri companion object Aug 30, 2019
@IndiscriminateCoding
Copy link
Contributor Author

@IndiscriminateCoding IndiscriminateCoding commented Aug 30, 2019

Binary compatibility checks are failed due to missing UrlCodingUtils object.
Is it OK (it was package-private) or should I make a PR against master?

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 3, 2019

It is okay to add exceptions for package privates.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Sep 19, 2019

Looks like this just needs MiMa exceptions.

Copy link
Member

@rossabaker rossabaker left a comment

Nice, thanks. 👍 on green. And let's squeeze it into #2874.

rossabaker added a commit to rossabaker/http4s that referenced this issue Sep 19, 2019
@rossabaker rossabaker merged commit e75815a into http4s:series/0.20 Sep 19, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants