Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upIntegrate socket options into Ember #2836
Conversation
vilu
force-pushed the
vilu:2768-integrate-socket-options-into-ember
branch
from
a42df47
to
446db52
|
Looks right to me. Thanks! |
This comment has been minimized.
This comment has been minimized.
|
Remember we should merge and check this is available once #2867 is in. |
This comment has been minimized.
This comment has been minimized.
|
I'll revert the last commits (with some attempts to do the necessary
upgrades) and prepare the branch for a merge.
Den ons 18 sep. 2019 kl 00:27 skrev Christopher Davenport <
notifications@github.com>:
… Remember we should merge and check this is available once #2867
<#2867> is in.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2836?email_source=notifications&email_token=AALLTVYBESXMMBW36KODUOTQKFKVLA5CNFSM4ITIIFD2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD66C6WA#issuecomment-532426584>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALLTVZJW5I6OLBN7DMRB4LQKFKVLANCNFSM4ITIIFDQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
vilu commentedSep 3, 2019
•
edited
This one shouldn't compile. I need to bump the fs2-io version but since it hasn't been published yet I can't. I open this one up just so that I can check that this is actually what's needed to be done.
Should fix: #2768