Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate socket options into Ember #2836

Merged

Conversation

@vilu
Copy link

vilu commented Sep 3, 2019

This one shouldn't compile. I need to bump the fs2-io version but since it hasn't been published yet I can't. I open this one up just so that I can check that this is actually what's needed to be done.

Should fix: #2768

viktor.lund
@vilu vilu force-pushed the vilu:2768-integrate-socket-options-into-ember branch from a42df47 to 446db52 Sep 3, 2019
Copy link
Member

rossabaker left a comment

Looks right to me. Thanks!

viktor.lund
@ChristopherDavenport

This comment has been minimized.

Copy link
Member

ChristopherDavenport commented Sep 17, 2019

Remember we should merge and check this is available once #2867 is in.

@vilu

This comment has been minimized.

Copy link
Author

vilu commented Sep 18, 2019

…2768-integrate-socket-options-into-ember
…-socket-options-into-ember
@ChristopherDavenport ChristopherDavenport marked this pull request as ready for review Sep 18, 2019
@rossabaker rossabaker merged commit 29975ac into http4s:master Sep 19, 2019
2 checks passed
2 checks passed
Summary no rules match, no planned actions
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vilu vilu deleted the vilu:2768-integrate-socket-options-into-ember branch Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.