Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor patches to logger #2889

Merged
merged 3 commits into from Oct 7, 2019
Merged

Minor patches to logger #2889

merged 3 commits into from Oct 7, 2019

Conversation

zakolenko
Copy link
Contributor

@zakolenko zakolenko commented Sep 26, 2019

  1. concat the message body more efficiently (using StringBuilder)
  2. client.middleware.Logger: log the prelude if logBody and logHeaders are false

Copy link
Member

@rossabaker rossabaker left a comment

Thanks. This looks good.

@aeons aeons merged commit 4cca43a into http4s:master Oct 7, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants