Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JettyClient: properly propagate streamed errors #2909

Conversation

IndiscriminateCoding
Copy link
Contributor

@IndiscriminateCoding IndiscriminateCoding commented Oct 11, 2019

Resolves #2901

The problem: any error that occurs in a Jetty client after headers were read isn't propagated to the body stream.
This results in weird behavior where client just hangs and its body never terminates.
This PR changes implementation of a ResponseListener to distinguish current response state and properly propagate error whether to callback or to body stream.

Copy link
Member

@rossabaker rossabaker left a comment

Thanks. This looks good to me. I think we could cherry-pick this back to 0.20 as well, since the changes are all in package privates.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Nov 26, 2019

This is cherry-picked into #2990 for release in 0.20.14.

@rossabaker rossabaker closed this Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants