Bugfix in the baze-core/util/IdentityWriter causing upload failure #2922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f chunked upload of data when Content-Length % Int32.Max > Int32.Max
mi-char
commented
Oct 23, 2019
| @@ -38,7 +38,7 @@ private[http4s] class IdentityWriter[F[_]](size: Int, out: TailStage[ByteBuffer] | |||
|
|
|||
| logger.warn(msg) | |||
|
|
|||
| val reducedChunk = chunk.take(size - bodyBytesWritten) | |||
| val reducedChunk = chunk.take((size - bodyBytesWritten).toInt) | |||
There was a problem hiding this comment.
Conversion to Int on this place is safe as long as chunk.size is also Int.
…f chunked upload of data when Content-Length (Long) converted to Int32 overflows to a positive number.
|
Please review this PR @rossabaker | @bryce-anderson | @ChristopherDavenport | @aeons This bug is causing us errors in production. |
rossabaker
approved these changes
Oct 30, 2019
|
Thank you. |
|
I can cherry pick it back tonight and get a release.going. |
|
That would be perfect. So I will leave on the master branch. |
Merged
|
This is cherry-picked and released as 0.20.12. |
aeons
added a commit
that referenced
this pull request
Nov 5, 2019
Backport #2922: chunked upload of long Content-Lengths
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug causes failure of a chunked upload in case when Content-Length (Long) converted to Int32 overflows to a positive number.
Test case: chunked upload of file with a content length 4,294,967,300 bytes.
Result:
IllegalArgumentException("Will not write more bytes than what was indicated by the Content-Length header 4")