Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Request.addCookie so it complies with the HTTP specification #2942

Merged
merged 2 commits into from Nov 5, 2019
Merged

Fix Request.addCookie so it complies with the HTTP specification #2942

merged 2 commits into from Nov 5, 2019

Conversation

@ghost
Copy link

@ghost ghost commented Nov 2, 2019

Relevant specification link

@ghost
Copy link
Author

@ghost ghost commented Nov 2, 2019

I cannot reproduce the failure in the test Blaze Http1Client should call a second host after reusing connections on a first:

Some(Left(())) != Some(Right(simple path)) (BlazeClientSpec.scala:337)

Anyone know what might have happened here? The test ran for the full 5 seconds, but someone else's pull request from earlier today seems to have run fine.

I do not see how my changes could have caused this; perhaps a Travis/JDK 11 issue?

@ghost ghost changed the title Fixing #2938 and associated tests Fixing Request.addCookie so it complies with the HTTP specification Nov 2, 2019
@ghost
Copy link
Author

@ghost ghost commented Nov 2, 2019

Okay then, simply building again with Travis worked... the Travis logs had some stuff about the SSL context so it must have just been a temporary outage of some sort.

@ghost ghost changed the title Fixing Request.addCookie so it complies with the HTTP specification Fix Request.addCookie so it complies with the HTTP specification Nov 2, 2019
@ghost ghost mentioned this pull request Nov 2, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Thanks. You are correct, even though it gets relaxed in HTTP/2.

This is a good candidate for 0.20. I will cherry-pick it and get it into the next patch release.

@rossabaker rossabaker added this to the 0.20.13 milestone Nov 4, 2019
@rossabaker rossabaker merged commit f3bd779 into http4s:master Nov 5, 2019
2 checks passed
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Nov 5, 2019

Oops, I meant to cherry-pick this first. Oh well, it'll be in the history twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants