Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate UrlCodingUItils methods #2946

Merged
merged 3 commits into from Nov 4, 2019
Merged

Deprecate UrlCodingUItils methods #2946

merged 3 commits into from Nov 4, 2019

Conversation

@amohrland
Copy link
Contributor

@amohrland amohrland commented Nov 2, 2019

I think this will resolve #2936. This adds back UrlCodingUtils methods, annotates them as deprecated, and forwards to corresponding Uri methods.

@amohrland
Copy link
Contributor Author

@amohrland amohrland commented Nov 2, 2019

Hmm, looks like build 9704.2 failed due to a test failure:

[error]   x behave and not deadlock on failures with parSequence (30 seconds, 108 ms)
[error]    None is not Some (BlazeClientSpec.scala:198)
[error] org.http4s.client.blaze.BlazeClientSpec.$anonfun$new$35(BlazeClientSpec.scala:198)

I think the test exceeded the 30 second timeout?

@ghost
Copy link

@ghost ghost commented Nov 2, 2019

I also had an issue with one of the tests in BlazeClientSpec yesterday (link) in which one of the tests timed out (5 seconds). The problem resolved itself when I did another build without any changes... I was not able to recreate it locally so I wonder if Travis is just spotty on this?

@amohrland
Copy link
Contributor Author

@amohrland amohrland commented Nov 2, 2019

Going to close and reopen to trigger another build.

@amohrland amohrland closed this Nov 2, 2019
@amohrland amohrland reopened this Nov 2, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Nice, thank you!

Yes, we have some flaky blaze tests that are troublesome on Travis but work locally. This has been a months long irritation. I think we need to wean ourselves from unsafeRunSync() in the tests, but that's a big job for other ticket(s).

@rossabaker rossabaker added this to the 0.20.13 milestone Nov 4, 2019
@rossabaker rossabaker merged commit 112fc0e into http4s:series/0.20 Nov 4, 2019
2 checks passed
@amohrland amohrland deleted the deprecate-urlcodingutils branch Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants