Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix switched local and remote addresses in servlet requests (0.20) #2953

Conversation

@nigredo-tori
Copy link
Contributor

@nigredo-tori nigredo-tori commented Nov 5, 2019

See #2952.

@nigredo-tori
Copy link
Contributor Author

@nigredo-tori nigredo-tori commented Nov 5, 2019

[info] decode should
[error]   x be consistent with utf8Decode (540 ms)
[error]    Falsified after 67 passed tests.
[error]    > ARG_0: "\u0008"
[error]    > ARG_0_ORIGINAL: "魂Ⲷਬ纅ᗀ赕Ὴᔱ鑰跎㎯쾼ዦ㷭"
[error]    > ARG_1: 1
[error]    > ARG_1_ORIGINAL: 1
[error]    > '' != ' (DecodeSpec.scala:24)

Not my fault. 😄

@rossabaker rossabaker added this to the 0.20.13 milestone Nov 5, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Good use of named params here. 👍

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Nov 5, 2019

This should be uncontroversial and we've got enough other things to keep our reviewers busy. Merging this with 1 so we can release.

@rossabaker rossabaker merged commit d70cd7e into http4s:series/0.20 Nov 5, 2019
1 of 2 checks passed
@nigredo-tori nigredo-tori deleted the 2952-fix-servlet-connection-info-0.20 branch Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants