Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a Request.cookies function #2965
Conversation
This comment has been minimized.
This comment has been minimized.
|
The scalafix error is I guess I will just close and re-open the pull request to trigger another Travis build... I assume this is another one of those flaky issues with Travis. |
|
|
||
| "parse discrete HTTP/1 Cookie header(s) into corresponding RequestCookies" in { | ||
| val cookies = Header("Cookie", "test1=value1; test2=value2; test3=value3") | ||
| val request = Request(Method.GET, headers = Headers.of(cookies)) |
This comment has been minimized.
This comment has been minimized.
kevinmeredith
Nov 10, 2019
Contributor
Does your test require specifying the HTTP version when constructing the Request?
This comment has been minimized.
This comment has been minimized.
ScalaFanatic
Nov 10, 2019
•
Author
Contributor
No. That should not impact the way the headers are handled. If I need to add that for semantics, I can, but this specifically refers to the way the cookies are being sent.
In practice, yes, the format would accompany
httpVersion = HttpVersion.`HTTP/2.0`
just because (for example) we would likely not see the HTTP/2 cookie format unless the request is HTTP/2. But for the purposes of my test I do not care about this.
This comment has been minimized.
This comment has been minimized.
| request.cookies mustEqual cookieList | ||
| } | ||
|
|
||
| "parse HTTP/1 and HTTP/2 Cookie headers on a single request into corresponding RequestCookies" in { |
This comment has been minimized.
This comment has been minimized.
…ent-request-cookies
This comment has been minimized.
This comment has been minimized.
|
This is backported into #2992. |
ScalaFanatic commentedNov 6, 2019
As discussed in #2943, it works with both HTTP/1 and HTTP/2.