Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve StaticFile.fromResource handling #3004

Merged
merged 1 commit into from Dec 2, 2019

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Dec 1, 2019

Should fix both #2468 and #2834

@hamnis hamnis requested a review from rossabaker Dec 1, 2019
@hamnis hamnis self-assigned this Dec 1, 2019
@hamnis hamnis force-pushed the static-file-resource branch 2 times, most recently from 36c02bc to 6604c0c Compare Dec 1, 2019
@rossabaker rossabaker added this to the 0.21.0 milestone Dec 1, 2019
Copy link
Member

@rossabaker rossabaker left a comment

Nice work. Should just need a scalafmt.

@hamnis hamnis force-pushed the static-file-resource branch from 6604c0c to 5f879f2 Compare Dec 1, 2019
@hamnis hamnis merged commit 43cded2 into http4s:master Dec 2, 2019
2 checks passed
@hamnis hamnis deleted the static-file-resource branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants