Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about Seqs #3008

Merged
merged 2 commits into from Dec 11, 2019
Merged

Conversation

ktfleming
Copy link
Contributor

@ktfleming ktfleming commented Dec 3, 2019

I think these may have been missed in c15b8ef.

hamnis
hamnis approved these changes Dec 4, 2019
Copy link
Member

@ChristopherDavenport ChristopherDavenport left a comment

Would prefer to just remove them all in favor of List since we are on a milestone.

Copy link
Member

@rossabaker rossabaker left a comment

Good find. I vote that we merge this, as it's certainly progress.

I also agree with @ChristopherDavenport that we should remove Seq from this interface altogether. This would include changing request.multiParams.

@rossabaker rossabaker merged commit 23ea890 into http4s:master Dec 11, 2019
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants