Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Mixed Content issue given forced HTTPS #3043

Merged
merged 1 commit into from Jan 7, 2020

Conversation

@blast-hardcheese
Copy link
Contributor

blast-hardcheese commented Jan 7, 2020

This seems to be the only issue with the old versions of the docs, it seems that v0.18+ started defaulting to HTTPS so this is only an issue with 0.15-0.17.

Thanks for the excellent docs, btw!

@hamnis
hamnis approved these changes Jan 7, 2020
Copy link
Contributor

hamnis left a comment

Great. Thanks!

Copy link
Member

rossabaker left a comment

Nice. Nothing in our automation goes back and republishes old versions when the site template changes, which gives rise to bugs like this. Note that this branch is the generated site, and not the actual source, so this will get stomped if we ever republish from the old branches. I would discourage PRs to this branch in general, but since those branches are EOL, I think it's appropriate here.

@rossabaker rossabaker merged commit f6b92ae into http4s:gh-pages Jan 7, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 44 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 2 redirect rules processed
Details
Summary no rules match, no planned actions
Details
deploy/netlify Deploy preview ready!
Details
@blast-hardcheese blast-hardcheese deleted the blast-hardcheese:fix-old-https branch Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.