Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Convenience Constructor for HttpDate #3051

Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 9, 2020

No description provided.

hamnis
hamnis approved these changes Jan 9, 2020
@ChristopherDavenport ChristopherDavenport merged commit 136ab44 into http4s:master Jan 9, 2020
2 checks passed
@ChristopherDavenport ChristopherDavenport deleted the currentHttpDate branch Jan 9, 2020
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 9, 2020

Do we really need both current and now? I like this one that takes the clock, but I'm not so sure I like the redundancy.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 9, 2020

now is not RT and should probably be deprecated, or replaced with this if we want to keep the now name despite changing the type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants