Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate HttpDate.now #3053

Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 9, 2020

Following Feedback from after #3051 was merged, deprecate HttpDate.now and instruct to use current instead.

@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 9, 2020

Other alternative: rename current -> now

Or rename now -> unsafeNow, current -> now

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 9, 2020

Need to clean up the deprecation warnings. I don't think we have much effectful header generation to this point, so it's going to introduce some maps and flatMaps.

I'm good with deprecating now. current has some JVM familarity (System.currentTimeMillis), and the deprecation will let people upgrade at their own pace and explain what needs to be done.

@ChristopherDavenport ChristopherDavenport merged commit f535d9f into http4s:master Jan 12, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants