Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning the CirceInstance implicits #3060

Merged
merged 1 commit into from Jan 21, 2020
Merged

Cleaning the CirceInstance implicits #3060

merged 1 commit into from Jan 21, 2020

Conversation

BalmungSan
Copy link
Contributor

@BalmungSan BalmungSan commented Jan 12, 2020

This PR applies to changes to the CirceInstances file.

The first one, replaces the combinations of Contex Bounds with implicit parameters.
The change leaves all methods with only one of them; bounds, only when neither of the implicits was explicitly required, and implicits otherwise.

The second one was to replace the two implicit classes with one value class and one implicit conversion.

Copy link
Member

@rossabaker rossabaker left a comment

👍 after we figure out that visibility question.

That test is #3058 cursing us again.

@rossabaker rossabaker added this to the 0.21.0-RC1 milestone Jan 18, 2020
@rossabaker rossabaker merged commit 2a406ba into http4s:master Jan 21, 2020
2 checks passed
@BalmungSan BalmungSan deleted the circe-instances-clean-implicits branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants