Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #3070 from ChristopherDavenport/contextRequestFunctor #3070

Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 14, 2020

Fixes part of #3059

Add a functor instance for ContextRequest

@ChristopherDavenport ChristopherDavenport changed the title Add ContextRequest Functor Add ContextRequest Traverse Jan 14, 2020
@ChristopherDavenport ChristopherDavenport changed the title Add ContextRequest Traverse Add ContextRequest NonEmptyTraverse Jan 14, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Extra credit if we can add an arbitrary and law test, but looks good.

core/src/main/scala/org/http4s/ContextRequest.scala Outdated Show resolved Hide resolved
@ChristopherDavenport
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport commented Jan 14, 2020

Oh goodness, looks like 2.13 can infer but 2.12 can't... Investigating.

@ChristopherDavenport ChristopherDavenport changed the title Add ContextRequest NonEmptyTraverse Merge pull request #3070 from ChristopherDavenport/contextRequestFunctor Jan 14, 2020
@ChristopherDavenport ChristopherDavenport merged commit ed8ef5c into http4s:master Jan 14, 2020
2 checks passed
@ChristopherDavenport ChristopherDavenport deleted the contextRequestFunctor branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants