Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection leak in PoolManger (#2962) #3086

Merged

Conversation

RafalSumislawski
Copy link
Member

@RafalSumislawski RafalSumislawski commented Jan 19, 2020

Fixes the issue I've described in this comment: #2962 (comment)

@rossabaker rossabaker added this to the 0.20.16 milestone Jan 20, 2020
Copy link
Member

@rossabaker rossabaker left a comment

Wonderful work tracking that down, including everyone who investigated on the original ticket.

I would not be surprised if we have to adjust these timeouts to prevent flakiness on Travis CI. These kind of tests would benefit from a test Clock, though I've tried and failed with Blaze's non-cats-effect internals. So we'll have to keep an eye out for that, but this looks good.

hamnis
hamnis approved these changes Jan 20, 2020
@rossabaker rossabaker merged commit 582ce82 into http4s:0.20.16 Jan 20, 2020
2 checks passed
rossabaker added a commit that referenced this issue Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants