Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server side ssl support for ember #3092

Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jan 21, 2020

Built on top of #3055

import scala.concurrent.duration.Duration

final class EmberClientBuilder[F[_]: Concurrent: Timer: ContextShift] private (
private val sslContextOpt: Option[(ExecutionContext, SSLContext)],
private val sgR: Resource[F, SocketGroup],
private val blockerOpt: Option[Blocker],
Copy link
Member Author

@ChristopherDavenport ChristopherDavenport Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can factor this out presently, as its only used to construct a SocketGroup if one is not provided, but I find it more likely that one would prefer to just apply a Blocker, and having it for the future is likely more useful for binary compatibility concerns as a lot of the fs2 operations require them. Just nothing I'm using at the moment.

Copy link
Member

@rossabaker rossabaker left a comment

👍

@rossabaker rossabaker added this to the 0.21.0-RC1 milestone Jan 21, 2020
@rossabaker rossabaker merged commit 723b2ea into http4s:master Jan 21, 2020
2 checks passed
rossabaker added a commit that referenced this issue Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants