New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add server side ssl support for ember #3092
Add server side ssl support for ember #3092
Conversation
import scala.concurrent.duration.Duration | ||
|
||
final class EmberClientBuilder[F[_]: Concurrent: Timer: ContextShift] private ( | ||
private val sslContextOpt: Option[(ExecutionContext, SSLContext)], | ||
private val sgR: Resource[F, SocketGroup], | ||
private val blockerOpt: Option[Blocker], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can factor this out presently, as its only used to construct a SocketGroup if one is not provided, but I find it more likely that one would prefer to just apply a Blocker, and having it for the future is likely more useful for binary compatibility concerns as a lot of the fs2 operations require them. Just nothing I'm using at the moment.
Built on top of #3055