Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new WS API which allows receiving Ping messages from the client #3136

Conversation

khrupalyk
Copy link

@khrupalyk khrupalyk commented Jan 31, 2020

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jan 31, 2020

Thanks. Don't we probably want to be able to receive Pong frames, too?

@khrupalyk
Copy link
Author

@khrupalyk khrupalyk commented Jan 31, 2020

Probably yes, we should.

@khrupalyk
Copy link
Author

@khrupalyk khrupalyk commented Jan 31, 2020

@rossabaker Updated PR.

@rossabaker rossabaker added this to the 0.21.0-RC3 milestone Feb 1, 2020
Copy link
Member

@rossabaker rossabaker left a comment

I think what you've done solves the problem and is limited enough for us being in release candidates.

I am fond of the interface in http4s-jdk-http-client, with its high-level and low-level distinction. I think it would be interesting to play with working this into the server, but that's a post-0.21 concern.

@rossabaker rossabaker added the breaking label Feb 1, 2020
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 1, 2020

Binary breaking, but not source breaking and should not be semantically breaking.

@rossabaker rossabaker merged commit c322455 into http4s:master Feb 3, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants