Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HttpRoutes.strict #3148

Merged
merged 4 commits into from Feb 6, 2020
Merged

Conversation

ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Feb 6, 2020

If users don't care about efficient route composition under a large number of routes, this exposes the ability of of as a partial function but only requires applicative and not of.

Open to different naming semantics. This change doesn't effect existing api and can be a patch if we don't want it in final, but I don't see why that's necessary for a convenience method like this.

@rossabaker rossabaker added the enhancement label Feb 6, 2020
@ChristopherDavenport ChristopherDavenport changed the title Add HttpRoutes.simple Add HttpRoutes.strict Feb 6, 2020
Copy link
Member

@rossabaker rossabaker left a comment

It would make sense to also add this to ContextRoutes, either here or in another PR. But LGTM.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 6, 2020

Failure is unrelated and #3149 should help.

@rossabaker rossabaker merged commit ec26c2e into http4s:master Feb 6, 2020
7 of 9 checks passed
rossabaker pushed a commit to rossabaker/http4s that referenced this issue Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants