Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResponseCookie parsing improvements (0.20.x) #3184

merged 3 commits into from Feb 11, 2020


Copy link

@rossabaker rossabaker commented Feb 11, 2020

Addresses #3178 in a binary compatible way.

  • Supports leading dot in domain. We punt on modeling it as a domain as opposed to a raw String.
  • Supports multiple extension attributes
  • Supports case-insensitive parsing of cookie attributes
  • Does not preserve non-extension attributes with the same name

@rossabaker rossabaker added the bug label Feb 11, 2020
@rossabaker rossabaker added this to the 0.20.18 milestone Feb 11, 2020
@rossabaker rossabaker changed the title Allow leading dot on Set-Cookie domain ResponseCookie parsing improvements (0.20.x) Feb 11, 2020
@aeons aeons merged commit 52894fc into http4s:series/0.20 Feb 11, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants