Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recover EOF on bodyEncoder.write to close connection #3185

Merged

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 11, 2020

Recover EOF raised by the body encoder rather than catching it as an exception, which some implementations may wrap. This better expresses intent and cleans up logs in such implementations.

/cc @jadlr

@rossabaker rossabaker added this to the 0.21.1 milestone Feb 11, 2020
hamnis
hamnis approved these changes Feb 11, 2020
@rossabaker rossabaker merged commit ffbd5e7 into http4s:series/0.21 Feb 11, 2020
8 checks passed
@rossabaker rossabaker deleted the recover-eof-on-bodyencoder-write branch Feb 11, 2020
@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Feb 11, 2020

This can be tested now in 0.21.0+12-ffbd5e7a-SNAPSHOT, published to OSS snapshots. It will be part of the 0.21.1 release, hopefully in the next day or so.

@jadlr
Copy link
Contributor

@jadlr jadlr commented Feb 11, 2020

Just deployed using the snapshot version. This fixes the issue 👍

Thanks for the quick fix!

rossabaker added a commit to rossabaker/http4s that referenced this issue Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants