Recover EOF on bodyEncoder.write to close connection #3185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamnis
approved these changes
Feb 11, 2020
|
This can be tested now in 0.21.0+12-ffbd5e7a-SNAPSHOT, published to OSS snapshots. It will be part of the 0.21.1 release, hopefully in the next day or so. |
|
Just deployed using the snapshot version. This fixes the issue 👍 Thanks for the quick fix! |
rossabaker
added a commit
to rossabaker/http4s
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recover EOF raised by the body encoder rather than catching it as an exception, which some implementations may wrap. This better expresses intent and cleans up logs in such implementations.
/cc @jadlr