Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace runtime reflection in HttpHeaderParser init #3190

Merged

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented Feb 12, 2020

Fixes #3189. The Graalers will appreciate it.

@rossabaker rossabaker added the enhancement label Feb 12, 2020
@rossabaker rossabaker added this to the 0.20.18 milestone Feb 12, 2020
addParser(key, parser)
}
private def gatherBuiltIn(): Unit = {
// This used to be based on reflection, which is bad for Graal, and
Copy link
Member

@cquiroz cquiroz Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to keep this commented code?

Copy link
Member

@cquiroz cquiroz Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I misunderstood, that is code to generate the addParser_ calls

Copy link
Member Author

@rossabaker rossabaker Feb 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it to show people how to regenerate it if necessary, but I don't think it has been touched in a long time, so it could probably go.

Copy link
Member

@cquiroz cquiroz left a comment

LGTM

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Feb 13, 2020

I confirmed that no headers were added after 0.20, so there should be no silent loss on merge.

@rossabaker
Copy link
Member Author

@rossabaker rossabaker commented Feb 13, 2020

And also confirmed that it works on http4s-native-image.

@rossabaker rossabaker merged commit 02c42e9 into http4s:series/0.20 Feb 13, 2020
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants