Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Caching Convenience Functions #3196

Merged

Conversation

ChristopherDavenport
Copy link
Member

No description provided.

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the cache spec inside-out, but this seems reasonable.

val headers = List(
`Cache-Control`(
NonEmptyList.of(
isPublic.fold[CacheDirective](identity, identity),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might be isPublic.merge?

@ChristopherDavenport
Copy link
Member Author

Will follow up on merge, want to squeeze this in.

@ChristopherDavenport ChristopherDavenport merged commit f319009 into http4s:master Feb 13, 2020
rossabaker added a commit to rossabaker/http4s that referenced this pull request Feb 14, 2020
@rossabaker
Copy link
Member

Oops. This missed the bus. There's a series/0.21. We already have a breaking change on master.

rossabaker added a commit that referenced this pull request Feb 14, 2020
rossabaker pushed a commit to rossabaker/http4s that referenced this pull request Mar 20, 2020
rossabaker added a commit to rossabaker/http4s that referenced this pull request Mar 22, 2020
rossabaker pushed a commit to rossabaker/http4s that referenced this pull request Mar 25, 2020
rossabaker pushed a commit to rossabaker/http4s that referenced this pull request Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants