Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uri fixes #3199

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Uri fixes #3199

merged 3 commits into from
Feb 13, 2020

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented Feb 13, 2020

Added scaladoc to Uri.withPath to describe behaviour
Be nice and add a / if the path does not have that and is non-empty.

Fixes #3197

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this can't be on series/0.20? I've been trying to backport bug fixes until we officially EOL it.

We talked about a short, but indefinite, wind down, but should put a date on it.

core/src/main/scala/org/http4s/Uri.scala Show resolved Hide resolved
core/src/main/scala/org/http4s/Uri.scala Outdated Show resolved Hide resolved
core/src/main/scala/org/http4s/Uri.scala Outdated Show resolved Hide resolved
@hamnis
Copy link
Contributor Author

hamnis commented Feb 13, 2020

Any reason this can't be on series/0.20? I've been trying to backport bug fixes until we officially EOL it.

We talked about a short, but indefinite, wind down, but should put a date on it.

No, no reason. i can move it there.

@rossabaker rossabaker added this to the 0.20.19 milestone Feb 13, 2020
Added scaladoc to Uri.withPath to describe behaviour
Be nice and add a / if the path does not have that and is non-empty.
Add addPath which adds segments from path
@hamnis hamnis changed the base branch from series/0.21 to series/0.20 February 13, 2020 20:11
@hamnis hamnis merged commit f84d6bf into http4s:series/0.20 Feb 13, 2020
@hamnis hamnis deleted the uri-path-fixes branch February 13, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants