Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer blackbox macros #3241

Merged
merged 2 commits into from Mar 19, 2020
Merged

Prefer blackbox macros #3241

merged 2 commits into from Mar 19, 2020

Conversation

travisbrown
Copy link
Contributor

@travisbrown travisbrown commented Mar 10, 2020

I noticed this while porting the macros to Dotty, and found this comment:

Also can't remember why these had to be whitebox instead of blackbox.

…but these definitely shouldn't need to be whitebox. Maybe there was an issue on 2.11? In any case tests pass with this change now.

@travisbrown
Copy link
Contributor Author

@travisbrown travisbrown commented Mar 10, 2020

Just noticed that illTyped can also be blackbox.

Copy link
Member

@rossabaker rossabaker left a comment

Thank you. I still can't recall why they used to be whitebox, but I'm glad to see proof that it works as blackbox.

hamnis
hamnis approved these changes Mar 18, 2020
@rossabaker rossabaker merged commit 1575b67 into http4s:master Mar 19, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants