Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer blackbox macros #3241

Merged
merged 2 commits into from
Mar 19, 2020
Merged

Prefer blackbox macros #3241

merged 2 commits into from
Mar 19, 2020

Conversation

travisbrown
Copy link
Contributor

I noticed this while porting the macros to Dotty, and found this comment:

Also can't remember why these had to be whitebox instead of blackbox.

…but these definitely shouldn't need to be whitebox. Maybe there was an issue on 2.11? In any case tests pass with this change now.

@travisbrown
Copy link
Contributor Author

Just noticed that illTyped can also be blackbox.

rossabaker
rossabaker approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I still can't recall why they used to be whitebox, but I'm glad to see proof that it works as blackbox.

@rossabaker rossabaker merged commit 1575b67 into http4s:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherDavenport ChristopherDavenport ChristopherDavenport approved these changes

@rossabaker rossabaker rossabaker approved these changes

@hamnis hamnis hamnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@travisbrown @hamnis @rossabaker @ChristopherDavenport