Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused EntityEncoder argument #3264

merged 1 commit into from Mar 21, 2020


Copy link

@travisbrown travisbrown commented Mar 20, 2020

This is a minor follow-up to #3253 that couldn't be included there because it breaks bincompat. The issue is that the EntityEncoder constraint here is unnecessary, but the compiler didn't warn because of the kind-projector syntax. This PR just removes the unnecessary parameter.

This change will have to wait for 0.22.x because it breaks bincompat, but it's source-compatible for normal usage.

hamnis approved these changes Mar 20, 2020
Copy link

@hamnis hamnis left a comment

test failures are unrelated

@rossabaker rossabaker merged commit b1822ad into http4s:master Mar 21, 2020
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants