Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose API changes #3271

Merged
merged 5 commits into from Apr 18, 2020
Merged

Conversation

tomasherman
Copy link
Contributor

@tomasherman tomasherman commented Mar 24, 2020

No description provided.

@rossabaker rossabaker added the breaking label Mar 25, 2020
Copy link
Member

@rossabaker rossabaker left a comment

This is breaking and can't go into 0.21.x, but I like it. 👍 after scalafmt.

@hamnis
Copy link
Contributor

@hamnis hamnis commented Mar 25, 2020

Test failures are genuine, 👍 on fix

@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Mar 25, 2020

Test failures are genuine, 👍 on fix

sure, working on it right now :)

@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Mar 25, 2020

not sure why CI / Scala 2.12.10, Java adopt@1.8 (pull_request) is failing at formatting stage

@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Mar 25, 2020

the failing test org.http4s.client.asynchttpclient.AsyncHttpClientSpec passes locally (using xcompilation +testOnly)

@hamnis
Copy link
Contributor

@hamnis hamnis commented Mar 25, 2020

from the formatting job. PrometheusServerMetricsSpec.scala isn't formatted properly!

try using sbt scalafmtAll

@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Mar 25, 2020

ah, i was only doing scalafmt

@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Apr 16, 2020

guys is this going to be merged? or should i do something?

Copy link
Member

@rossabaker rossabaker left a comment

Yes, sorry for the delay. I've been working in bursts since I acquired the additional title of schoolteacher this month. Thanks for the enhancement!

@rossabaker rossabaker merged commit d0dcde3 into http4s:master Apr 18, 2020
8 checks passed
@tomasherman
Copy link
Contributor Author

@tomasherman tomasherman commented Apr 18, 2020

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 18, 2020

We've discussed splitting the repo up along module boundaries, but I haven't considered going all the way to the middleware level. I'm also aggressively backporting whatever is compatible, but that doesn't help you on this one.

I'd like to start publishing milestones off master for users who can accomodate more churn, which might scratch your itch. Otherwise, a third-party module for the 0.21 lifecycle is probably the fastest way to start using this.

armanbilge pushed a commit to http4s/http4s-prometheus-metrics that referenced this issue May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants