Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type parameter from org.http4s.server.Server #3291

Merged
merged 2 commits into from Apr 3, 2020

Conversation

satorg
Copy link
Contributor

@satorg satorg commented Apr 1, 2020

From server/src/main/scala/org/http4s/server/Server.scala:

abstract class Server[F[_]] {
  ...
}

As per conversation with @rossabaker, this type parameter looks like a legacy and isn't actually used anymore.

@satorg
Copy link
Contributor Author

@satorg satorg commented Apr 1, 2020

BTW, the following tests are failing on my local machine even without my changes:

  • org.http4s.client.jetty.JettyClientSpec
  • org.http4s.client.okhttp.OkHttpClientSpec

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 2, 2020

Hmm, it's much more common for tests to fail on CI than locally. If you paste the errors, I might be able to make a suggestion.

That said, this is almost there. We just need to clean up the reference in the tut. Link to error.

@satorg
Copy link
Contributor Author

@satorg satorg commented Apr 2, 2020

Fixed. It seems it is fine now)

@satorg
Copy link
Contributor Author

@satorg satorg commented Apr 3, 2020

@rossabaker:

Hmm, it's much more common for tests to fail on CI than locally. If you paste the errors, I might be able to make a suggestion.

I have created a PR (#3294) which describes the issue and suggests a fix for it:
Could you take a look please?

Copy link
Member

@rossabaker rossabaker left a comment

👍 Thanks!

hamnis
hamnis approved these changes Apr 3, 2020
@rossabaker rossabaker merged commit 0a06d94 into http4s:master Apr 3, 2020
8 checks passed
@satorg satorg deleted the untaglessify-server branch Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants