Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop deprecated methods from #3323

Merged
merged 1 commit into from Apr 15, 2020
Merged

Conversation

diesalbla
Copy link
Contributor

@diesalbla diesalbla commented Apr 13, 2020

  • The method newDefaultFixedThreadPool was deprecated years ago,
    and it was also marked as internal to http4s.

  • The method charsetRangesNoQuality is part of the laws tests,
    has a default mapping, and has been deprecated for a while.

- The method `newDefaultFixedThreadPool` was deprecated years ago,
  and it was also marked as internal to http4s.

- The method `charsetRangesNoQuality` is part of the laws tests,
  has a default mapping, and has been deprecated for a while.
Copy link
Member

@rossabaker rossabaker left a comment

Gosh, these flaky tests are a nuisance. 👍

@hamnis hamnis merged commit bc1e7cb into http4s:master Apr 15, 2020
7 of 8 checks passed
@diesalbla diesalbla deleted the drop_015_deprecations branch Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants