Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http2 support in JettyBuilder #3333

Closed
wants to merge 1 commit into from

Conversation

rolandomanrique
Copy link
Contributor

@rolandomanrique rolandomanrique commented Apr 17, 2020

Enables HTTP2CServerConnectionFactory in JettyConnector which only supports http2 over plain text connections.

For http2 over ssl this would require ALPN configuration on the SSL context.

Copy link
Member

@rossabaker rossabaker left a comment

Code is great. Extra dependency is debatable, but I don't have a better idea.

@@ -260,7 +260,8 @@ lazy val jetty = libraryProject("jetty")
.settings(
description := "Jetty implementation for http4s servers",
libraryDependencies ++= Seq(
jettyServlet
jettyServlet,
jettyHttp2Server
Copy link
Member

@rossabaker rossabaker Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces a new dependency that people won't use by default, which is not great, but I don't want to create another Jetty module, and optional dependencies are frustrating. I think this is the least of all evils.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 20, 2020

I don't think the additional dependencies here are scary, and the release cycle is the same as the extant dependencies. I think we can cherry pick this one to a maintenance branch to get it released sooner.

@rossabaker rossabaker added the enhancement label Apr 20, 2020
@rossabaker rossabaker added this to the 0.20.22 milestone Apr 20, 2020
@rossabaker rossabaker added the retarget label Apr 20, 2020
@rossabaker
Copy link
Member

@rossabaker rossabaker commented Apr 26, 2020

Backported to series/0.20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement retarget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants