Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace tut with mdoc #3358

Closed
wants to merge 1 commit into from
Closed

Replace tut with mdoc #3358

wants to merge 1 commit into from

Conversation

iRevive
Copy link
Contributor

@iRevive iRevive commented Apr 27, 2020 •
edited

This PR closes #3259.

There was no activity related to the ticket, thus I decided to pick it up.

rossabaker
rossabaker reviewed Apr 27, 2020
View changes
Copy link
Member

@rossabaker rossabaker left a comment

Oh, this is exciting. I wonder whether this cleanly applies to series/0.21 branch, since we'll be maintaining that for a while as we continue to evolve master? series/0.20 will be EOL this week, so we don't need to go that far back.

@rossabaker rossabaker added the docs label Apr 27, 2020
@rossabaker rossabaker added the retarget label May 9, 2020
@rossabaker
Copy link
Member

rossabaker commented May 9, 2020

This one developed some merge conflicts. I'd like to have it on 0.21, so I'm cherry-picking back to that, and will deal with the mess. Thanks again. I've wanted this one for a very long time.

rossabaker pushed a commit that referenced this issue May 9, 2020
@iRevive @rossabaker
Backport #3358: Replace tut with mdoc
8fe90ca
@rossabaker rossabaker mentioned this pull request May 9, 2020
Merged
@rossabaker
Copy link
Member

rossabaker commented May 9, 2020 •
edited

Oops, I did not mean to push 8fe90ca to this branch. Never mind, that's just a reference from the backport draft.

@rossabaker rossabaker closed this May 9, 2020
@rossabaker
Copy link
Member

rossabaker commented May 9, 2020

Or close it. Argh.

@rossabaker rossabaker reopened this May 9, 2020
@rossabaker
Copy link
Member

rossabaker commented May 9, 2020

Ah! mdoc runs clean on 2.12.11, but generates (fatal) warnings on 2.13. That's why the build passed and my local development didn't.

aeons added a commit that referenced this issue May 11, 2020
@aeons
Merge pull request #3399 from http4s/mdoc-0.21
9aa5e81 
Backport #3358: Replace tut with mdoc
@rossabaker
Copy link
Member

rossabaker commented May 11, 2020

This is included in #3399 and now has conflicts. I think the next interesting work is to make mdoc work on 2.13, for which we should open a separate ticket.

@rossabaker rossabaker closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossabaker rossabaker

Assignees
No one assigned
Labels
docs retarget
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Docs] Port tut to mdoc
2 participants
@iRevive @rossabaker