Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/deployment #3374

Merged
merged 7 commits into from May 11, 2020
Merged

Docs/deployment #3374

merged 7 commits into from May 11, 2020

Conversation

apple-corps
Copy link
Contributor

@apple-corps apple-corps commented May 4, 2020

No description provided.

@apple-corps apple-corps mentioned this pull request May 4, 2020
Copy link
Member

@rossabaker rossabaker left a comment

@Drocsid, this is wonderful! There are a massive number of suggestions below, but it's almost entirely about typography and consistency. This will be a great addition.

docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
@rossabaker rossabaker added the docs Relates to our website or tutorials label May 8, 2020
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
docs/src/main/tut/deployment.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@apple-corps apple-corps left a comment

I was allowed to batch 26/27 suggestions with the exception of suggestion on the same line. Regarding the other changes I am not sure how to make them part of the batch edit.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented May 8, 2020

I guess this is how the batching feature works? 🤷‍♂️

To add the suggestion to a batch of changes, click Add suggestion to batch. Continue to add the suggested changes you want to include in a single commit. When you've finished adding suggested changes, click Commit suggestions.

I wouldn't really worry about any subsequent edits being part of the batch. In fact, it's likely easier to look at them if they're not.

Copy link
Contributor Author

@apple-corps apple-corps left a comment

I must have chose the wrong button regarding applying the batch. It's been resolved and I think I've addressed all the comments.

@rossabaker rossabaker merged commit ead5830 into http4s:master May 11, 2020
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Relates to our website or tutorials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants