Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with CIString from case-insensitive library #3390

Merged
merged 4 commits into from May 19, 2020

Conversation

rossabaker
Copy link
Member

@rossabaker rossabaker commented May 9, 2020

Part of the effort to move non-HTTP things out of http4s.

I'd like to replace com.rossabaker.ci with org.typelevel (see typelevel/general#102), but it will look something like this. I don't think the .ci syntax carries its weight, and would like to phase it out.

@rossabaker rossabaker added the breaking label May 9, 2020
@@ -1837,7 +1837,7 @@ This release is identical to v0.19.0-M4. We mistagged it. Please proceed to th
implementors, with more to follow. Added an `HttpCodecLaws` to http4s-testing.
* `Uri.Scheme` is now its own type instead of a type alias.
* `TransferCoding` is no longer a case class. Its `coding` member is now a
`String`, not a `CaseInsensitiveString`. Its companion is no longer a
`String`, not a `CIString`. Its companion is no longer a
Copy link
Member

@aeons aeons May 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these historical changes should not refer to the new name,

Copy link
Member Author

@rossabaker rossabaker May 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, good catch. You caught my overzealous search and replace.

aeons
aeons approved these changes May 10, 2020
Copy link
Member

@aeons aeons left a comment

Do you want to merge it now, or wait until it's moved under typelevel?

@rossabaker
Copy link
Member Author

rossabaker commented May 10, 2020

It's probably better to make only one breaking change. There hasn't been much response on the Typelevel ticket. If they don't want it, we could also transfer it to http4s. I just thought I'd offer it up higher since it's not HTTP.

hamnis
hamnis approved these changes May 11, 2020
aeons
aeons approved these changes May 19, 2020
@rossabaker
Copy link
Member Author

rossabaker commented May 19, 2020

Force-push was just a scalafmt I cleaned up after the fact.

@rossabaker rossabaker merged commit af4a5b5 into http4s:master May 19, 2020
9 of 10 checks passed
@rossabaker rossabaker deleted the ci-string branch May 19, 2020
rossabaker added a commit to http4s/http4s-servlet that referenced this issue Apr 3, 2022
Replace with CIString from case-insensitive library
armanbilge pushed a commit to http4s/http4s-async-http-client that referenced this issue May 20, 2022
Replace with CIString from case-insensitive library
armanbilge pushed a commit to http4s/http4s-okhttp-client that referenced this issue May 20, 2022
Replace with CIString from case-insensitive library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants