Replace with CIString from case-insensitive library #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeons
reviewed
May 10, 2020
| @@ -1837,7 +1837,7 @@ This release is identical to v0.19.0-M4. We mistagged it. Please proceed to th | |||
| implementors, with more to follow. Added an `HttpCodecLaws` to http4s-testing. | |||
| * `Uri.Scheme` is now its own type instead of a type alias. | |||
| * `TransferCoding` is no longer a case class. Its `coding` member is now a | |||
| `String`, not a `CaseInsensitiveString`. Its companion is no longer a | |||
| `String`, not a `CIString`. Its companion is no longer a | |||
There was a problem hiding this comment.
I guess these historical changes should not refer to the new name,
There was a problem hiding this comment.
Oh, good catch. You caught my overzealous search and replace.
aeons
approved these changes
May 10, 2020
|
It's probably better to make only one breaking change. There hasn't been much response on the Typelevel ticket. If they don't want it, we could also transfer it to http4s. I just thought I'd offer it up higher since it's not HTTP. |
hamnis
approved these changes
May 11, 2020
aeons
approved these changes
May 19, 2020
|
Force-push was just a scalafmt I cleaned up after the fact. |
rossabaker
added a commit
to http4s/http4s-servlet
that referenced
this pull request
Apr 3, 2022
Replace with CIString from case-insensitive library
armanbilge
pushed a commit
to http4s/http4s-async-http-client
that referenced
this pull request
May 20, 2022
Replace with CIString from case-insensitive library
armanbilge
pushed a commit
to http4s/http4s-okhttp-client
that referenced
this pull request
May 20, 2022
Replace with CIString from case-insensitive library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort to move non-HTTP things out of http4s.
I'd like to replace com.rossabaker.ci with org.typelevel (see typelevel/general#102), but it will look something like this. I don't think the
.cisyntax carries its weight, and would like to phase it out.