This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An alternative that would permit the old restrictions in that DSL would be to make every Method value an object. Then each value would have its own type, and we could add syntax for POST.type, GET.type, etc. This would make the DSL implementation noisier, and prevent the change of Method to a final class.
Another option is to phase out this DSL entirely, which I don't think has worked out well in practice. I know @SystemFw has argued for phasing it out. We can make it gentle if we keep code like we did here, but also deprecate it.
breakingChange breaks compatibility (binary or source)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.