Model Accept-Patch header #3450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cquiroz
reviewed
May 22, 2020
| @@ -120,6 +120,17 @@ object Header { | |||
| } | |||
| } | |||
|
|
|||
| /** Helper trait that provides a default way of rendering the value provided a Renderer */ | |||
| trait RecurringRenderer extends Recurring { | |||
There was a problem hiding this comment.
This is equivalent to RecurringRenderable but for `Renderer
cquiroz
reviewed
May 22, 2020
| /** Helper trait that provides a default way of rendering the value provided a Renderer */ | ||
| trait RecurringRenderer extends Recurring { | ||
| type Value | ||
| implicit val renderer: Renderer[Value] |
There was a problem hiding this comment.
Any ideas on how to initialize this by default? My attempts ended poorly
There was a problem hiding this comment.
Eager abstract values make me nervous. How about a def?
cquiroz
reviewed
May 22, 2020
| @@ -46,7 +46,7 @@ class HeadersSpec extends Http4sSpec { | |||
| Header("Accept-Patch", ""), | |||
| Header("Access-Control-Allow-Credentials", "") | |||
| ) | |||
| headers.get(`Accept-Patch`).map(_.value) must beSome("") | |||
| headers.get(`Access-Control-Allow-Credentials`).map(_.value) must beSome("") | |||
There was a problem hiding this comment.
I'm not sure about the meaning of this test
There was a problem hiding this comment.
I think it was just making sure that we could get headers when we had a key but not a full model. I don't think it's a great test, and what you did is fine.
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
Signed-off-by: Carlos Quiroz <carlos.m.quiroz@gmail.com>
|
Rebased and fixed comment |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
As part of modeling headers, here's
Accept-Patch