Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated *Service #3460

Merged
merged 1 commit into from Jun 24, 2020
Merged

Remove deprecated *Service #3460

merged 1 commit into from Jun 24, 2020

Conversation

hamnis
Copy link
Contributor

@hamnis hamnis commented May 28, 2020

Removes *Service types and Constructors as they are redundant and have been deprecated for a few releases.

Removes *Service types and Constructors as they are redunant
and have been deprecated for a few releases.
Copy link
Member

@rossabaker rossabaker left a comment

I have a habit of holding onto deprecated things until they absolutely stop compiling or drag along unwanted dependencies. I've been at shops that don't get to upgrade often, and having the helping hand from deprecation notices is helpful. But I also know it's tiresome for other contributors.

I'm very mildly opposed, but I also know I'm an outlier in this and won't stand in the way. 😄

@ChristopherDavenport
Copy link
Member

@ChristopherDavenport ChristopherDavenport commented Jun 24, 2020

I really don't mind either way. But I hate the tail of the dead code. So I'm ok with this. It has been 2 versions. If we are going to hold onto stuff perhaps we should define what an "appropriate" period to upgrade is.

@rossabaker
Copy link
Member

@rossabaker rossabaker commented Jun 24, 2020

Well, I'm also much more open to this if we keep upping our scalafix game.

@rossabaker rossabaker merged commit 63184fc into http4s:master Jun 24, 2020
10 checks passed
@hamnis hamnis deleted the service-B-gone branch Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants