Remove deprecated *Service #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes *Service types and Constructors as they are redunant and have been deprecated for a few releases.
rossabaker
reviewed
May 31, 2020
There was a problem hiding this comment.
I have a habit of holding onto deprecated things until they absolutely stop compiling or drag along unwanted dependencies. I've been at shops that don't get to upgrade often, and having the helping hand from deprecation notices is helpful. But I also know it's tiresome for other contributors.
I'm very mildly opposed, but I also know I'm an outlier in this and won't stand in the way. 😄
ChristopherDavenport
approved these changes
Jun 24, 2020
|
I really don't mind either way. But I hate the tail of the dead code. So I'm ok with this. It has been 2 versions. If we are going to hold onto stuff perhaps we should define what an "appropriate" period to upgrade is. |
|
Well, I'm also much more open to this if we keep upping our scalafix game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes *Service types and Constructors as they are redundant and have been deprecated for a few releases.